mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54628: Changed 'Socket::create()' in IOSwitchboard to always be of 'kind' POLL.
Date Sun, 11 Dec 2016 05:26:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54628/#review158791
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54627, 54628]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 11, 2016, 4:35 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54628/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2016, 4:35 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This includes updating the IOSwitchboard 'connect()' call to always
> connect to the switchboard with the HTTP scheme.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c

>   src/tests/containerizer/io_switchboard_tests.cpp ecadeee179fc2a22967b324928bfb11e140a6987

> 
> Diff: https://reviews.apache.org/r/54628/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER-"" make -j check
> GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message