mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54561: Added tests for IOSwitchboard heartbeat.
Date Sun, 11 Dec 2016 05:03:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54561/#review158790
-----------------------------------------------------------




src/tests/containerizer/io_switchboard_tests.cpp (lines 392 - 396)
<https://reviews.apache.org/r/54561/#comment229587>

    there is already a `deserialize` function in common/http.hpp that you can use. see api_tests.cpp
for examples.



src/tests/containerizer/io_switchboard_tests.cpp (lines 434 - 439)
<https://reviews.apache.org/r/54561/#comment229588>

    hmm. instead of depending on real time, can you just pause the clock and use `clock::advance`?
otherwise it is going to be flaky depending on the load of the test machine.


- Vinod Kone


On Dec. 9, 2016, 2:10 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54561/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 2:10 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-6763
>     https://issues.apache.org/jira/browse/MESOS-6763
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for IOSwitchboard heartbeat.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp 43f1ad6c13d25dca1e316ea9e622566a2af1c45d

> 
> Diff: https://reviews.apache.org/r/54561/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> 
> I ran the tests below individually to avoid the unix domain socket bug currently being
worked on, which causes two tests in the second test to fail if run in the same process as
the first.
> 
> GTEST_FILTER="*SendHeartbeat*" src/mesos-tests
> GTEST_FILTER="*ReceiveHeartbeat*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message