mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54560: Added a bi-directional heartbeat for IOSwitchboard connections.
Date Sun, 11 Dec 2016 04:52:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54560/#review158789
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Dec. 11, 2016, 1:03 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54560/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2016, 1:03 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-6763
>     https://issues.apache.org/jira/browse/MESOS-6763
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a bi-directional heartbeat for IOSwitchboard connections.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 9d5c3e786cbb89416bb9a423569602b8b2549752 
>   include/mesos/v1/agent/agent.proto d0fdf293c40d8c797711077e40c483c6a059004a 
>   src/slave/containerizer/mesos/io/switchboard.hpp ae4c48d3ce0252189bc1a098c26f25ba30c870c9

>   src/slave/containerizer/mesos/io/switchboard.cpp a354188a3656b5c2fd797b214f6c02714d70ce2c

>   src/slave/containerizer/mesos/io/switchboard_main.cpp 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd

> 
> Diff: https://reviews.apache.org/r/54560/diff/
> 
> 
> Testing
> -------
> 
> Tests in subsequent patch. Because of a pending unix domain socket reconnect bug, committing
the tests and running them in the standard way would break the build currently.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message