mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 54508: Added a TTY test for LAUNCH_NESTED_CONTAINER_SESSION.
Date Sat, 10 Dec 2016 18:32:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54508/#review158587
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/api_tests.cpp (line 3861)
<https://reviews.apache.org/r/54508/#comment229363>

    Nit: Quotes before `TTYInfo`



src/tests/api_tests.cpp (line 3862)
<https://reviews.apache.org/r/54508/#comment229364>

    s/stederr/stderr


- Anand Mazumdar


On Dec. 8, 2016, 9:51 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54508/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 9:51 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Test verifies that output and error are sent as stdout to client.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61 
> 
> Diff: https://reviews.apache.org/r/54508/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message