mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 54627: Forced variant of 'http::connect()' to use POLL even when SSL enabled.
Date Sat, 10 Dec 2016 18:29:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54627/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and Joseph Wu.


Bugs: MESOS-6775
    https://issues.apache.org/jira/browse/MESOS-6775


Repository: mesos


Description
-------

The 'http::connect(address)' variant of 'http::connect()' doesn't
currently support SSL. However, when SSL is enabled, the default for
all 'Socket::create()' calls is to use the 'DEFAULT_KIND()' of socket
which is set to SSL. This causes problems with 'connect()' because it
will create a socket of 'kind' SSL without a way to override it.

This commit forces all calls to this variant of 'connect()' to
explicitly set 'kind' to 'POLL' in the 'Socket::create()' call.


Diffs
-----

  3rdparty/libprocess/src/http.cpp c0eaeff28ea5005d4dfae32118cb8e0f5e650a67 

Diff: https://reviews.apache.org/r/54627/diff/


Testing
-------

../configure --enable-ssl --enable-libevent
GTEST_FILTER="" make -j check
src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message