mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.
Date Sat, 10 Dec 2016 01:13:49 GMT


> On Dec. 10, 2016, 12:37 a.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/isolators/xfs/disk.cpp, lines 110-120
> > <https://reviews.apache.org/r/54449/diff/1/?file=1578141#file1578141line110>
> >
> >     We check 
> >     
> >     ```
> >       if (!xfs::pathIsXfs(flags.work_dir)) {
> >         return Error("'" + flags.work_dir + "' is not an XFS filesystem");
> >       }
> >     ```
> >     
> >     in `XfsDiskIsolatorProcess::create`. Seems like the similar check should go
there if we want to "fail fast".

This check is in `XfsDiskIsolatorProcess::create`. The diff viewer is misleading ;)


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54449/#review158517
-----------------------------------------------------------


On Dec. 6, 2016, 9:21 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54449/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 9:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6732
>     https://issues.apache.org/jira/browse/MESOS-6732
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The XFS disk isolator checks that the filesystem is XFS, but doesn't
> check whether project quotas are actually enabled. This means that
> an invalid configuration will start but will always fail when tasks
> are launched.
> 
> Add a check to test whether project quotas are enabled on the work
> directory and fail hard if they are not.
> 
> 
> Diffs
> -----
> 
>   configure.ac 5fb2efffaf62652d59c832da9c0f7e1b43a64ee4 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp dd4df86bf90bfa9cbf4664d89274cf3c64c2e374

>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 7602fe3b6ab069db643397418732e773d0417f8a

>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp b9d8e7dc999ba3064bee7105eff0f9553d825df8

> 
> Diff: https://reviews.apache.org/r/54449/diff/
> 
> 
> Testing
> -------
> 
> Make check on Fedora 25. Manual test on F25 with mesos-execute.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message