mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54524: Updated `resources()` method to return resources used by role.
Date Fri, 09 Dec 2016 11:37:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54524/#review158666
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54524]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 9, 2016, 9:39 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54524/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 9:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
> 
> 
> Bugs: MESOS-6685
>     https://issues.apache.org/jira/browse/MESOS-6685
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently `resources()` method in `struct Role` of master.hpp returns
> totalUsedResources and totalOfferedResources for a framework, which is
> inaccurate for multi-role frameworks. A filter is added to capture the
> actual resources for specific role in multi-role frameworks.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp d3c20d7cbb9137d3b05cae3d67f004d5e7475c8a 
>   src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 
> 
> Diff: https://reviews.apache.org/r/54524/diff/
> 
> 
> Testing
> -------
> 
> make check on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message