mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54555: Removed using declarations in headers in global scope in libprocess.
Date Fri, 09 Dec 2016 02:19:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54555/#review158624
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54553, 54554, 54555]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 8, 2016, 11:05 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54555/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 11:05 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp 60f40eada741b1caf81247a396a179e2b7d79ac0

>   3rdparty/libprocess/include/process/windows/subprocess.hpp e2ba7526b65b0a88cb297ec7cf52701f27b1abd0

> 
> Diff: https://reviews.apache.org/r/54555/diff/
> 
> 
> Testing
> -------
> 
> `make check` (OS X, clang w/ libc++, various Linux setups in internal CI)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message