mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54560: Added a heartbeat for both input/output connections on an IOSwitchboard.
Date Fri, 09 Dec 2016 01:55:14 GMT


> On Dec. 9, 2016, 1:44 a.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/io/switchboard.cpp, line 1518
> > <https://reviews.apache.org/r/54560/diff/1/?file=1580187#file1580187line1518>
> >
> >     hmm. instead of `UNREACHABLE` this should return `BadRequest` or `Unimplemented`.
this will handle the case when a client sends a new type of control message that the SB doesn't
understand yet (old version)

This is handled in the validator (which does return bad request). This line should actually
be unreachable because of the validation done.


> On Dec. 9, 2016, 1:44 a.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/io/switchboard.cpp, line 1558
> > <https://reviews.apache.org/r/54560/diff/1/?file=1580187#file1580187line1558>
> >
> >     ditto. see above.

Ditto


> On Dec. 9, 2016, 1:44 a.m., Vinod Kone wrote:
> > src/slave/flags.cpp, line 267
> > <https://reviews.apache.org/r/54560/diff/1/?file=1580190#file1580190line267>
> >
> >     see below: should we name it in a generic way? e.g., "--enable_debugging"

I will defer this to Jie. I am indifferent. What do you think?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54560/#review158616
-----------------------------------------------------------


On Dec. 9, 2016, 1:55 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54560/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 1:55 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-6763
>     https://issues.apache.org/jira/browse/MESOS-6763
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a heartbeat for both input/output connections on an IOSwitchboard.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 9d5c3e786cbb89416bb9a423569602b8b2549752 
>   include/mesos/v1/agent/agent.proto d0fdf293c40d8c797711077e40c483c6a059004a 
>   src/slave/containerizer/mesos/io/switchboard.hpp ae4c48d3ce0252189bc1a098c26f25ba30c870c9

>   src/slave/containerizer/mesos/io/switchboard.cpp 93a6b274f7ecb8e2fcd4bb74b266d999e89e2b02

>   src/slave/containerizer/mesos/io/switchboard_main.cpp 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd

>   src/slave/flags.hpp 02af2845e8c2baf03c83c7eab897725f6e2e9752 
>   src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3 
> 
> Diff: https://reviews.apache.org/r/54560/diff/
> 
> 
> Testing
> -------
> 
> Tests in subsequent patch. Because of a pending unix domain socket reconnect bug, committing
the tests and running them in the standard way would break the build currently.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message