mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54560: Added a heartbeat for both input/output connections on an IOSwitchboard.
Date Fri, 09 Dec 2016 01:55:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54560/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 1:55 a.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
-------

Updated based on Vinod's comments. I left two issues open, take a look.


Bugs: MESOS-6763
    https://issues.apache.org/jira/browse/MESOS-6763


Repository: mesos


Description
-------

Added a heartbeat for both input/output connections on an IOSwitchboard.


Diffs (updated)
-----

  include/mesos/agent/agent.proto 9d5c3e786cbb89416bb9a423569602b8b2549752 
  include/mesos/v1/agent/agent.proto d0fdf293c40d8c797711077e40c483c6a059004a 
  src/slave/containerizer/mesos/io/switchboard.hpp ae4c48d3ce0252189bc1a098c26f25ba30c870c9

  src/slave/containerizer/mesos/io/switchboard.cpp 93a6b274f7ecb8e2fcd4bb74b266d999e89e2b02

  src/slave/containerizer/mesos/io/switchboard_main.cpp 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd

  src/slave/flags.hpp 02af2845e8c2baf03c83c7eab897725f6e2e9752 
  src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3 

Diff: https://reviews.apache.org/r/54560/diff/


Testing
-------

Tests in subsequent patch. Because of a pending unix domain socket reconnect bug, committing
the tests and running them in the standard way would break the build currently.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message