mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54281: Added new test for LAUNCH_NESTED_CONTAINER_SESSION.
Date Thu, 08 Dec 2016 21:32:59 GMT


> On Dec. 8, 2016, 8:02 p.m., Anand Mazumdar wrote:
> > src/tests/api_tests.cpp, line 3811
> > <https://reviews.apache.org/r/54281/diff/2/?file=1579553#file1579553line3811>
> >
> >     hmm, we should change it to `ASSERT_EQ` since the next step would likely crash
if the size is 0.
> >     
> >     There are other tests that do so, would be worth doing a sweep later.

i'll add a dependent review that fixes this for `containerIds`


> On Dec. 8, 2016, 8:02 p.m., Anand Mazumdar wrote:
> > src/tests/api_tests.cpp, line 3787
> > <https://reviews.apache.org/r/54281/diff/2/?file=1579553#file1579553line3787>
> >
> >     Kill this?

IIRC we need this because when we do `driver.stop()` at the end of test, it will result in
updates and offers


> On Dec. 8, 2016, 8:02 p.m., Anand Mazumdar wrote:
> > src/tests/api_tests.cpp, line 3797
> > <https://reviews.apache.org/r/54281/diff/2/?file=1579553#file1579553line3797>
> >
> >     Kill this?

see above.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54281/#review158473
-----------------------------------------------------------


On Dec. 8, 2016, 9:32 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54281/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 9:32 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that launch results in output being streamed.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61 
> 
> Diff: https://reviews.apache.org/r/54281/diff/
> 
> 
> Testing
> -------
> 
> make -j20 check GTEST_FILTER="*LaunchNestedContainerSession*"  GLOG_v=1 MESOS_VERBOSE=1
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message