mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.
Date Thu, 08 Dec 2016 18:33:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 8, 2016, 6:33 p.m.)

Review request for mesos, Joseph Wu and Vinod Kone.


Updated comments.

Bugs: MESOS-3753

Repository: mesos


This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.

Diffs (updated)

  3rdparty/libprocess/include/process/ssl/gtest.hpp 2a19b3b1e09517151bddb43a128f45457da4ca8a

  3rdparty/libprocess/src/tests/ssl_tests.cpp 7fa46e4cc3e1225e9c9591fb5a1fb8d90c165c01 



Testing details are found at the end of this chain.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message