mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Review Request 54524: Updated `resources()` method to return resources used by role.
Date Thu, 08 Dec 2016 07:10:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54524/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Guangya Liu.


Bugs: MESOS-6685
    https://issues.apache.org/jira/browse/MESOS-6685


Repository: mesos


Description
-------

Currently `resources()` method in `struct Role` of master.hpp returns
totalUsedResources and totalOfferedResources for a framework, which is
inaccurate for multi-role frameworks. A filter is added to filter out
actual resources for specific role in a framework.


Diffs
-----

  src/master/master.hpp d3c20d7cbb9137d3b05cae3d67f004d5e7475c8a 
  src/master/master.cpp 353e6ea802e197b4456c1647f78d9984a50f1c9d 

Diff: https://reviews.apache.org/r/54524/diff/


Testing
-------

This patch is just to showcase a possible solution for accounting resources used by a role
in multi-role framework. It fails certain test cases since `allocation_info` is not filled
yet.


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message