mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53803: Added a new libprocess HTTP test.
Date Thu, 08 Dec 2016 02:38:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53803/#review158485
-----------------------------------------------------------




3rdparty/libprocess/src/tests/http_tests.cpp (lines 15 - 16)
<https://reviews.apache.org/r/53803/#comment229256>

    Is this header still required?



3rdparty/libprocess/src/tests/http_tests.cpp (lines 222 - 224)
<https://reviews.apache.org/r/53803/#comment229253>

    Why are both of these inner scopes in the same test?  They could be entirely separate
tests, right?



3rdparty/libprocess/src/tests/http_tests.cpp (line 238)
<https://reviews.apache.org/r/53803/#comment229258>

    This will run into an error on Windows, as the `server_address` is the (invalid) 0.0.0.0
IP.
    
    See: https://github.com/apache/mesos/blob/1350f946a3aa12e9b2b66720e81b5a4ba4c4d90d/3rdparty/libprocess/src/tests/http_tests.cpp#L1784-L1794
    
    Ditto in the second block.


- Joseph Wu


On Dec. 6, 2016, 11:28 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53803/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 11:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-5966
>     https://issues.apache.org/jira/browse/MESOS-5966
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds HTTPTest.SocketEOF to verify that EOFs are
> reliably received whether or not there is a pending recv()
> request at the time the EOF is received.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 7f5425742d554b78fd4788c4a453068a604e1f46

> 
> Diff: https://reviews.apache.org/r/53803/diff/
> 
> 
> Testing
> -------
> 
> Testing details are at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message