mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53709: Remuved warnings from gzip.hpp.
Date Wed, 07 Dec 2016 23:58:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53709/#review158446
-----------------------------------------------------------




3rdparty/stout/include/stout/gzip.hpp (line 126)
<https://reviews.apache.org/r/53709/#comment229220>

    This line should have the same warning right?



3rdparty/stout/include/stout/gzip.hpp (line 192)
<https://reviews.apache.org/r/53709/#comment229221>

    We should cast to the same type.  In this case, a `uInt`.


- Joseph Wu


On Nov. 13, 2016, 9:45 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53709/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Remuved warnings from gzip.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/gzip.hpp 97891860dbdd7095d5498695ad0e97ad02e35d73 
> 
> Diff: https://reviews.apache.org/r/53709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message