mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54502: Made the default 'Accept-Type' be JSON on the Agent API.
Date Wed, 07 Dec 2016 23:55:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54502/#review158443
-----------------------------------------------------------


Ship it!




Good catch!

- Vinod Kone


On Dec. 7, 2016, 10:25 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54502/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 10:25 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There might be existing clients that might not be setting the
> 'Accept-Type' header. If so, they would break if we change the
> default accept type to being `APPLICATION_STREAMING_JSON`.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 0c0e769ba51d3da0f0b4ae90e8b29a94b3248889 
>   src/tests/api_tests.cpp 6cd1f83a47731ee8c4fb1f022bf585b271b3b966 
> 
> Diff: https://reviews.apache.org/r/54502/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message