mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54494: Fixed container-logger subprocess environment setup.
Date Wed, 07 Dec 2016 20:47:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54494/#review158392
-----------------------------------------------------------




src/slave/container_loggers/lib_logrotate.cpp (line 89)
<https://reviews.apache.org/r/54494/#comment229153>

    you probably want to set LIBPROCESS_IP to 127.0.0.1. Otherwise, the hostname lookup might
fail in some environment.


- Jie Yu


On Dec. 7, 2016, 8:44 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54494/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 8:44 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-6747
>     https://issues.apache.org/jira/browse/MESOS-6747
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_loggers/lib_logrotate.cpp 27726abd7f5bd42b0f368f00c524c7eaabee38c0

> 
> Diff: https://reviews.apache.org/r/54494/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message