mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54496: Made the IO Switchboard wait for the reader to signal before exiting.
Date Wed, 07 Dec 2016 20:34:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54496/#review158387
-----------------------------------------------------------


Ship it!





src/slave/containerizer/mesos/io/switchboard.cpp (line 1102)
<https://reviews.apache.org/r/54496/#comment229146>

    do you want to do a VLOG here incase it ever blocks here?


- Vinod Kone


On Dec. 7, 2016, 8:15 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54496/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 8:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6746
>     https://issues.apache.org/jira/browse/MESOS-6746
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The switchboard never used to wait for the read end of the pipe
> to finish processing the data before exiting. This was problematic
> as the client connected to the output entrypoint might not receive
> the data. Note that we are relying on `socket.close()` to
> eventually ensure that the data is flushed to the client when the
> socket is closed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 4452d5ad26881487825e58a3a052e6d07bac2321

> 
> Diff: https://reviews.apache.org/r/54496/diff/
> 
> 
> Testing
> -------
> 
> make check (A test is added later in the chain that won't pass otherwise)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message