mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54487: Used agent environment variables for I/O switchboard.
Date Wed, 07 Dec 2016 20:26:41 GMT


> On Dec. 7, 2016, 8:19 p.m., Benjamin Bannier wrote:
> > src/slave/containerizer/mesos/io/switchboard.cpp, line 547
> > <https://reviews.apache.org/r/54487/diff/2/?file=1578948#file1578948line547>
> >
> >     Should this be an `AND` instead of an `OR`? Alternatively go for
> >     
> >         if (!(strings::startsWith(key, "LIBPROCESS_") ||
> >               strings::startsWith(key, "MESOS_"))) {

GOOD CATCH!


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54487/#review158384
-----------------------------------------------------------


On Dec. 7, 2016, 7:28 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54487/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 7:28 p.m.)
> 
> 
> Review request for mesos, Joseph Wu, Kevin Klues, and Till Toenshoff.
> 
> 
> Bugs: MESOS-6748
>     https://issues.apache.org/jira/browse/MESOS-6748
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> THe I/O switchboard server process will inheirt most of the agent
> environment variables, except for those that are prefixed with MESOS
> or LIBPROCESS since we don't rely on those environment variables.
> 
> The patch also manually set a few LIBPROCESS environment variables to
> make sure the libprocess for the I/O switchboard can be initailzied
> properly without depending on external environment.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 4452d5ad26881487825e58a3a052e6d07bac2321

> 
> Diff: https://reviews.apache.org/r/54487/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message