mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <>
Subject Re: Review Request 54200: Added a helper function to get roles from FrameworkInfo.
Date Wed, 07 Dec 2016 08:59:40 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 7, 2016, 4:59 p.m.)

Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang.


This is a helper function to facilitate MESOS-6635. Actual functional changes of allocator
will be submitted in separate patches from BenM.

Summary (updated)

Added a helper function to get roles from FrameworkInfo.

Bugs: MESOS-6635

Repository: mesos

Description (updated)

The function returns a set<string> containing all roles in a
multi-role FrameworkInfo. For single-role FrameworkInfo, there
is only one element in the set.

Diffs (updated)

  src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4 
  src/common/protobuf_utils.cpp 56e16648ae138ed6da40811144b721cd82b5f8a0 


Testing (updated)


Jay Guo

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message