mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54360: Changed master to add/remove roles for a multi-role framework.
Date Wed, 07 Dec 2016 04:32:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54360/#review158298
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp (line 7033)
<https://reviews.apache.org/r/54360/#comment229071>

    Thinking about this again, we probably should avoid capturing the framework pointer and
instead take it explicitly:
    
    ```
    auto addFrameworkRole = [this](Framework* framework, const string& role) {
    
    auto removeFrameworkRole = [this](Framework* framework, const string& role) {
    ```


- Benjamin Mahler


On Dec. 7, 2016, 3:58 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54360/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 3:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6684
>     https://issues.apache.org/jira/browse/MESOS-6684
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a multi-role framework registers, master should add roles
> from 'roles' field of FrameworkInfo to internal data structure
> `activeRoles`. On the other hand, master should remove framework
> from all the roles it subscribed with.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 
> 
> Diff: https://reviews.apache.org/r/54360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message