mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54465: Added synchronization between agent and IOSwitchboard server for listen.
Date Wed, 07 Dec 2016 03:21:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54465/
-----------------------------------------------------------

(Updated Dec. 7, 2016, 3:21 a.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
-------

Added a test and fixed a small bug in `main` (which was never writing anything to the pipe
originally!).


Bugs: MESOS-6737
    https://issues.apache.org/jira/browse/MESOS-6737


Repository: mesos


Description
-------

We use a pipe to synchronize with the io switchboard process to
determine when it is ready to listen for incoming connections. We do
not block the launch path with this pipe, but rather poll on it and
block incoming connections until it is ready.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.hpp f691b182d4029a15bbb3b1c158b176d43f265cc1

  src/slave/containerizer/mesos/io/switchboard.cpp c54d64efe7dc526473427bca89a1b65205e16018

  src/slave/containerizer/mesos/io/switchboard_main.cpp 6ce4cdb08e3e15eda21dcb740c4390613a88f5c5

  src/tests/containerizer/io_switchboard_tests.cpp 851a1015294882ca5401cb8fd60ceff6f933249d


Diff: https://reviews.apache.org/r/54465/diff/


Testing
-------

GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message