mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54441: Added function to unblock IOSwitchboard when waiting for connection.
Date Tue, 06 Dec 2016 21:07:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54441/#review158215
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/io/switchboard.cpp (lines 892 - 894)
<https://reviews.apache.org/r/54441/#comment229006>

    I would just call 'set' here. No need for the if check here.


- Jie Yu


On Dec. 6, 2016, 7:58 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54441/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 7:58 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6664
>     https://issues.apache.org/jira/browse/MESOS-6664
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added function to unblock IOSwitchboard when waiting for connection.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065

>   src/slave/containerizer/mesos/io/switchboard.cpp 19f2b625f2aa4b790fbe80b8dfad44b219f2c24e

> 
> Diff: https://reviews.apache.org/r/54441/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message