mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.
Date Tue, 06 Dec 2016 19:37:39 GMT


> On Dec. 6, 2016, 5:31 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/io/switchboard.cpp, line 161
> > <https://reviews.apache.org/r/54355/diff/5/?file=1577431#file1577431line161>
> >
> >     or agent crashes right before we create the directory and fork the server.

Would we actually have an active container state in this case though? If the agent crashed
at that point, then you would never have gotten the cahnce to even try and launch the container
itself.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54355/#review158121
-----------------------------------------------------------


On Dec. 6, 2016, 4:55 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54355/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 4:55 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6688
>     https://issues.apache.org/jira/browse/MESOS-6688
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation of `recover()` to the IOSwitchboard isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065

>   src/slave/containerizer/mesos/io/switchboard.cpp 19f2b625f2aa4b790fbe80b8dfad44b219f2c24e

> 
> Diff: https://reviews.apache.org/r/54355/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> Test added in follow-on patch.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message