mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 54414: Cleaned up rlimits documentation.
Date Tue, 06 Dec 2016 11:21:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54414/#review158145
-----------------------------------------------------------




docs/posix_rlimits.md (line 6)
<https://reviews.apache.org/r/54414/#comment228893>

    s/##/#



docs/posix_rlimits.md (line 10)
<https://reviews.apache.org/r/54414/#comment228896>

    I'm not sure we do that.



docs/posix_rlimits.md (line 13)
<https://reviews.apache.org/r/54414/#comment228897>

    s/###/##



docs/posix_rlimits.md (line 32)
<https://reviews.apache.org/r/54414/#comment228898>

    s/###/##
    s/For/for (see https://github.com/apache/mesos/blob/master/docs/markdown-style-guide.md)



docs/posix_rlimits.md (line 38)
<https://reviews.apache.org/r/54414/#comment228899>

    I think we should use indentation for non-c++ blobs. https://github.com/apache/mesos/blob/master/docs/markdown-style-guide.md


- Alexander Rukletsov


On Dec. 6, 2016, 10:41 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54414/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 10:41 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-6427
>     https://issues.apache.org/jira/browse/MESOS-6427
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * added front matter,
> * add section headers,
> * remove stray double spaces,
> * used canonical delimiter for guarded code blocks, and
> * used HTML table to enable canonical styling, see also MESOS-6729.
> 
> 
> Diffs
> -----
> 
>   docs/posix_rlimits.md 0a0e6a8d20eb87852e0ce635b2de2caed94b7020 
> 
> Diff: https://reviews.apache.org/r/54414/diff/
> 
> 
> Testing
> -------
> 
> Checked with bundled site setup.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message