mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.
Date Tue, 06 Dec 2016 02:05:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54355/#review158097
-----------------------------------------------------------




src/slave/containerizer/mesos/io/switchboard.cpp (lines 147 - 148)
<https://reviews.apache.org/r/54355/#comment228803>

    Update this comemnts here?



src/slave/containerizer/mesos/io/switchboard.cpp (lines 206 - 210)
<https://reviews.apache.org/r/54355/#comment228804>

    Do you need to check the existence of the io_switchboard directory as well. It's likely
the container we want to recover here does not have io_switchboard directory (do not use io
switchboard server).



src/slave/containerizer/mesos/io/switchboard.cpp (lines 217 - 220)
<https://reviews.apache.org/r/54355/#comment228806>

    I don't think we want to fail the agent recovery if the previous agent run crashed at
an unfortunate time.
    
    Also, if a container is in active container list (recoverable), that means the io switchboard
pid must exist with proper value. Otherwise, it should not be part of the recoverable list.
I'll probably return a Failure for that case.
    
    Also, I would do the recovering of active containers first. Then, deal with orphans.



src/slave/containerizer/mesos/io/switchboard.cpp (lines 648 - 650)
<https://reviews.apache.org/r/54355/#comment228807>

    `cleanup` might be called for legacy containers that do not have io switchboard server.
For those containers, we probably don't want to create an Info for them.
    
    Therefore, we should probably ignore unknown container here. Please add a comment here
about why we ignore unknown container here.


- Jie Yu


On Dec. 6, 2016, 12:21 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54355/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 12:21 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6688
>     https://issues.apache.org/jira/browse/MESOS-6688
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added implementation of `recover()` to the IOSwitchboard isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065

>   src/slave/containerizer/mesos/io/switchboard.cpp 19f2b625f2aa4b790fbe80b8dfad44b219f2c24e

> 
> Diff: https://reviews.apache.org/r/54355/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> Test added in follow-on patch.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message