mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.
Date Tue, 06 Dec 2016 01:06:42 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 6, 2016, 1:06 a.m.)

Review request for mesos and Alex Clemmer.


Remove dependency.

Bugs: MESOS-6677

Repository: mesos


This commit fixes MESOS-6677, which breaks the ability
to run any agent on Windows, and thus is blocking all
Windows development progress on the `master` branch.

The cause was that the default `runtime_dir` value was POSIX specific,
and used `os::user()` which is deleted on Windows.
The fix is to guard the POSIX code, and add a
Windows implementation.


  src/slave/constants.hpp 6c381f06365b9deb84f43cdd101a2d2e5d826f57 
  src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 



make && make check on Linux: 1411 tests passed, no failures.

msbuild and attached to Linux master: no runtime failures.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message