mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54356: Added implementation of `watch()` to the 'IOSwitchboard' isolator.
Date Tue, 06 Dec 2016 00:27:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54356/
-----------------------------------------------------------

(Updated Dec. 6, 2016, 12:27 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Updated to remove check for `io_switchboard_enable_server` (which was made unnecessary by
updated to previous patches).


Bugs: MESOS-6663
    https://issues.apache.org/jira/browse/MESOS-6663


Repository: mesos


Description
-------

We use watch() to trigger the destruction of a container if the
io switchboard server process ever exits unexpectedly.


Diffs (updated)
-----

  include/mesos/mesos.proto 657dcb8edde3154efec21bd147663fc704f97482 
  include/mesos/v1/mesos.proto 36c122784daa190e25903e8bd4a05f7f1507c304 
  src/slave/containerizer/mesos/io/switchboard.hpp 839665a22aca9b1c1c1cf4992406bc924ee2b065

  src/slave/containerizer/mesos/io/switchboard.cpp 19f2b625f2aa4b790fbe80b8dfad44b219f2c24e

  src/tests/containerizer/io_switchboard_tests.cpp c8fe8768db705d97299215ab69b91babb8bbc2f9


Diff: https://reviews.apache.org/r/54356/diff/


Testing
-------

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message