mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.
Date Tue, 06 Dec 2016 00:10:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54336/
-----------------------------------------------------------

(Updated Dec. 6, 2016, 12:10 a.m.)


Review request for mesos and Alex Clemmer.


Changes
-------

Updated with test results.


Bugs: MESOS-6677
    https://issues.apache.org/jira/browse/MESOS-6677


Repository: mesos


Description
-------

The default `runtime_dir` value was POSIX specific,
and caused https://issues.apache.org/jira/browse/MESOS-6677.

The constant was removed in preparation for `os::runstatedir` refactor.

We unblock the Windows agent by guarding the POSIX code on Windows.


Diffs
-----

  src/slave/constants.hpp 6c381f06365b9deb84f43cdd101a2d2e5d826f57 
  src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 

Diff: https://reviews.apache.org/r/54336/diff/


Testing (updated)
-------

make && make check on Linux: 1411 tests passed, no failures.

msbuild and attached to Linux master: no runtime failures.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message