mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.
Date Tue, 06 Dec 2016 00:10:15 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 6, 2016, 12:10 a.m.)

Review request for mesos and Alex Clemmer.


Updated with test results.

Bugs: MESOS-6677

Repository: mesos


The default `runtime_dir` value was POSIX specific,
and caused

The constant was removed in preparation for `os::runstatedir` refactor.

We unblock the Windows agent by guarding the POSIX code on Windows.


  src/slave/constants.hpp 6c381f06365b9deb84f43cdd101a2d2e5d826f57 
  src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 


Testing (updated)

make && make check on Linux: 1411 tests passed, no failures.

msbuild and attached to Linux master: no runtime failures.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message