mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.
Date Mon, 05 Dec 2016 05:48:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/#review157961
-----------------------------------------------------------




src/slave/containerizer/mesos/io/switchboard.cpp (lines 407 - 417)
<https://reviews.apache.org/r/54352/#comment228631>

    I would probably wait until the io switchboard process has been terminated. Otherwise,
rm here might get EBUSY?
    
    In other words, move this logic to `status.then`



src/slave/containerizer/mesos/io/switchboard.cpp (line 416)
<https://reviews.apache.org/r/54352/#comment228630>

    I would still LOG(ERROR) if rm fails.


- Jie Yu


On Dec. 5, 2016, 12:39 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54352/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 12:39 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6689
>     https://issues.apache.org/jira/browse/MESOS-6689
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added removal of unix domain socket path in IOSwitchboard::cleanup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 778367a268ec350ed438bc9fe9d359d63bdb5503

> 
> Diff: https://reviews.apache.org/r/54352/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message