mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54351: Allowed subprocess to take duplicated FDs.
Date Mon, 05 Dec 2016 04:54:15 GMT


> On Dec. 5, 2016, 1:36 a.m., Kevin Klues wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 330-344
> > <https://reviews.apache.org/r/54351/diff/2/?file=1576051#file1576051line330>
> >
> >     I feel like moving this into the windows `createChildProcess()` function would
make it more semetrical with the change above. It seems odd that we would ahve to close out
here on windows, but not on posix.
> >     
> >     Also, lines 318 and 326 above should either be removed (if you follow my suggestion)
or changed to be the same as this line (if you don't).

This part the code needs to be refactored. The logic is really hard to follow when I did the
change. I'll add a TODO for now because I don't have a good way to test windows code.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54351/#review157936
-----------------------------------------------------------


On Dec. 5, 2016, 12:16 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54351/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 12:16 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kevin Klues.
> 
> 
> Bugs: MESOS-6470
>     https://issues.apache.org/jira/browse/MESOS-6470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed subprocess to take duplicated FDs.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp aa4609d9e4c63f824c8cd631f39bbbe71e4f67b4

>   3rdparty/libprocess/include/process/windows/subprocess.hpp f452f6743d01f0b99010fa5e5bcbaae1358c8241

>   3rdparty/libprocess/src/subprocess.cpp 284e22e28ae8d2c1486e4a6bea743b8663ce2023 
> 
> Diff: https://reviews.apache.org/r/54351/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message