mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54294: Added an I/O switchboard test with TTY enabled.
Date Mon, 05 Dec 2016 02:10:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54294/#review157939
-----------------------------------------------------------




src/tests/containerizer/io_switchboard_tests.cpp (lines 307 - 308)
<https://reviews.apache.org/r/54294/#comment228616>

    Why not put this at the top with the other declaration for `IOSwitchboardServerTest`?



src/tests/containerizer/io_switchboard_tests.cpp (line 344)
<https://reviews.apache.org/r/54294/#comment228617>

    Can you add a quick comment about what's going on here (and why it's important for testing
the tty redirection).


- Kevin Klues


On Dec. 5, 2016, 12:17 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54294/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 12:17 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kevin Klues.
> 
> 
> Bugs: MESOS-6470
>     https://issues.apache.org/jira/browse/MESOS-6470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an I/O switchboard test with TTY enabled.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/io_switchboard_tests.cpp d82f22b5c9a8d177577db3aeaae9e571e7e2fb80

> 
> Diff: https://reviews.apache.org/r/54294/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message