mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 54013: Added user doc for nested container and task group.
Date Sun, 04 Dec 2016 19:44:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157928
-----------------------------------------------------------


Fix it, then Ship it!




LGTM.


docs/nested-container-and-task-group.md (line 28)
<https://reviews.apache.org/r/54013/#comment228588>

    this does not sound like they have the same life cycle?



docs/nested-container-and-task-group.md (line 41)
<https://reviews.apache.org/r/54013/#comment228589>

    abstractions



docs/nested-container-and-task-group.md (line 70)
<https://reviews.apache.org/r/54013/#comment228591>

    Both authorized operators and executors...



docs/nested-container-and-task-group.md (line 105)
<https://reviews.apache.org/r/54013/#comment228592>

    Maybe link to https://github.com/apache/mesos/blob/master/docs/app-framework-development-guide.md
for details about default executor?



docs/nested-container-and-task-group.md (line 209)
<https://reviews.apache.org/r/54013/#comment228593>

    mention that only 2 levels of nesting is supported as of 1.1?


- Vinod Kone


On Nov. 30, 2016, 7:11 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54013/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Qian Zhang, and
Vinod Kone.
> 
> 
> Bugs: MESOS-6335
>     https://issues.apache.org/jira/browse/MESOS-6335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added user doc for nested container and task group.
> 
> 
> Diffs
> -----
> 
>   docs/nested-container-and-task-group.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54013/diff/
> 
> 
> Testing
> -------
> 
> Tested by gist view. Here is the link:
> 
> https://github.com/Gilbert88/mesos/blob/doc_pod/docs/nested-container-and-task-group.md
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message