mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54343: Pulled the validation code from `deserializer()`.
Date Sat, 03 Dec 2016 22:06:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54343/#review157908
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54342, 54337, 54340, 54343]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 3, 2016, 7:49 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54343/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 7:49 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It was weird that the deserializer was validating the call too
> on the Agent API. The validation is now done by the
> `read()`/`readAll()` continuations.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 8b104ce9ca6e72a1e76943f0d68a0541a45e39f6 
> 
> Diff: https://reviews.apache.org/r/54343/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message