mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54302: Added three tests to ensure master validates roles.
Date Sat, 03 Dec 2016 02:11:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54302/#review157882
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, just some minor suggestions.


src/tests/master_validation_tests.cpp (line 2465)
<https://reviews.apache.org/r/54302/#comment228503>

    s/RejectFrameworkWithRolesWithoutMultipleRoleCapability/MissingMultiRoleCapability



src/tests/master_validation_tests.cpp (lines 2472 - 2475)
<https://reviews.apache.org/r/54302/#comment228501>

    Can you just set one role here? It should fail if the roles field is used at all, not
just if there are multiple roles. Be sure to update the test comments accordingly.



src/tests/master_validation_tests.cpp (lines 2523 - 2524)
<https://reviews.apache.org/r/54302/#comment228504>

    s/RejectMultiRoleFrameworkWithNonWhitelistedRole/MultiRoleWhitelist/


- Benjamin Mahler


On Dec. 3, 2016, 1:55 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54302/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 1:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Guangya Liu.
> 
> 
> Bugs: MESOS-6629
>     https://issues.apache.org/jira/browse/MESOS-6629
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Frameworks should fail on subscription with invalid settings of
> 'roles'. Otherwise master should accept subscription.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp 5c44967a077551944831383a6bcc6dcb1c626df9 
> 
> Diff: https://reviews.apache.org/r/54302/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message