mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 54300: Added a test for validateRoles method.
Date Sat, 03 Dec 2016 01:49:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54300/
-----------------------------------------------------------

(Updated Dec. 3, 2016, 1:49 a.m.)


Review request for mesos, Benjamin Mahler and Guangya Liu.


Changes
-------

addressed ben's comments.


Bugs: MESOS-6629
    https://issues.apache.org/jira/browse/MESOS-6629


Repository: mesos


Description
-------

There are three attributes: 'role', 'roles' and MULTI_ROLE to be
validated by this method, therefore covered by 2^3 test cases.
Also the test ensures this method checks duplicate entries in 'roles'.


Diffs (updated)
-----

  src/tests/master_validation_tests.cpp 5c44967a077551944831383a6bcc6dcb1c626df9 

Diff: https://reviews.apache.org/r/54300/diff/


Testing (updated)
-------

make
make check

./bin/mesos-tests.sh  --gtest_filter="FrameworkInfoValidationTest.*"
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from FrameworkInfoValidationTest
[ RUN      ] FrameworkInfoValidationTest.ValidateRoles
[       OK ] FrameworkInfoValidationTest.ValidateRoles (1 ms)
[ RUN      ] FrameworkInfoValidationTest.RejectFrameworkWithRolesWithoutMultipleRoleCapability
[       OK ] FrameworkInfoValidationTest.RejectFrameworkWithRolesWithoutMultipleRoleCapability
(286 ms)
[ RUN      ] FrameworkInfoValidationTest.AcceptMultiRoleFramework
[       OK ] FrameworkInfoValidationTest.AcceptMultiRoleFramework (303 ms)
[ RUN      ] FrameworkInfoValidationTest.RejectMultiRoleFrameworkWithNonWhitelistedRole
[       OK ] FrameworkInfoValidationTest.RejectMultiRoleFrameworkWithNonWhitelistedRole (296
ms)
[----------] 4 tests from FrameworkInfoValidationTest (887 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (910 ms total)
[  PASSED  ] 4 tests.


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message