mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 53890: Tweaked usage of `getFramework`.
Date Fri, 02 Dec 2016 20:49:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53890/#review157820
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Nov. 21, 2016, 9:26 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53890/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 9:26 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6419
>     https://issues.apache.org/jira/browse/MESOS-6419
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In a few places, calls to `getFramework` can be hoisted out of an inner
> loop. This improves code clarity (as well as maybe saving a few cycles).
> 
> A call to `getFramework` can be hoisted out of an inner loop.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a 
> 
> Diff: https://reviews.apache.org/r/53890/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message