mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54297: Added support for ATTACH_CONTAINER_INPUT to the io switchboard.
Date Fri, 02 Dec 2016 18:52:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54297/#review157789
-----------------------------------------------------------




src/slave/containerizer/mesos/io/switchboard.cpp (lines 947 - 954)
<https://reviews.apache.org/r/54297/#comment228393>

    Let's put this into stout/posix/os.hpp and call it `os::setWindowSize(unsigned short row,
unsigned short column)`


- Jie Yu


On Dec. 2, 2016, 6:54 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54297/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Jie Yu.
> 
> 
> Bugs: MESOS-6467
>     https://issues.apache.org/jira/browse/MESOS-6467
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for ATTACH_CONTAINER_INPUT to the io switchboard.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 594c37e531c5b26599989a126aede56954d460fa

> 
> Diff: https://reviews.apache.org/r/54297/diff/
> 
> 
> Testing
> -------
> 
> This is not tesedt yet. I plan to write a test and update this patch soon. Just wanted
to get a preliminary patch out there for review.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message