mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 53887: Improved FaultToleranceTest.FrameworkReregister.
Date Fri, 02 Dec 2016 18:43:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53887/#review157784
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/fault_tolerance_tests.cpp (line 807)
<https://reviews.apache.org/r/53887/#comment228388>

    the new style is to omit "Times(1)" because that's the default.


- Vinod Kone


On Nov. 18, 2016, 7:14 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53887/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2016, 7:14 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6419
>     https://issues.apache.org/jira/browse/MESOS-6419
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Code cleanup; also check output of the "/state" endpoint.
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp 1a8888de7faee56d394de30b798982dbb6e32f81 
> 
> Diff: https://reviews.apache.org/r/53887/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message