mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 54310: Added missing break statements.
Date Fri, 02 Dec 2016 17:40:45 GMT


> On Dec. 2, 2016, 5:38 p.m., Benjamin Bannier wrote:
> > There's already https://reviews.apache.org/r/54304/.

Sure, either change is fine -- although benh is probably too busy to review. Note that this
_is_ a functional change.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54310/#review157766
-----------------------------------------------------------


On Dec. 2, 2016, 4:55 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54310/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Spotted via Coverity.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/address.hpp 01bc065b45ff1a4c38f245b49078cc06dbb11249

> 
> Diff: https://reviews.apache.org/r/54310/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message