mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 54304: Added explicit break statements in switch.
Date Fri, 02 Dec 2016 10:48:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54304/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
-------

The expectation here was that only one case would match so no
intentional fall-through would happen. Make this explicit by adding
break statements.

This was noted by coverity in CID 1396669.


Diffs
-----

  3rdparty/libprocess/include/process/address.hpp 01bc065b45ff1a4c38f245b49078cc06dbb11249


Diff: https://reviews.apache.org/r/54304/diff/


Testing
-------

`make check` (OS X).

This is not expected to be a functional change.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message