mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 54275: Fixed inaccurate documentation of `--hostname` for master and agent.
Date Fri, 02 Dec 2016 09:37:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54275/#review157721
-----------------------------------------------------------



Patch looks great!

Reviews applied: [54275]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 2, 2016, 12:26 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54275/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This comment is inaccurate since the introduction of
> `LIBPROCESS_ADVERTISE_IP`, which introduced the distinction between the
> IP that we bind to vs advertise.
> 
> If the `--hostname` flag is unset, it is resolved from the IP address
> that the master/agent advertises. This may happen to be same as the IP
> address that we bind to, but ultimately we resolve it based on the
> advertise IP.
> 
> 
> Diffs
> -----
> 
>   src/master/flags.cpp 9bfb40e22820c3ced40b128280ec63288fea8b41 
>   src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 
> 
> Diff: https://reviews.apache.org/r/54275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message