mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 54275: Fixed inaccurate documentation of `--hostname` for master and agent.
Date Fri, 02 Dec 2016 00:20:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54275/#review157678
-----------------------------------------------------------


Ship it!




I think your summary is one character too long and your description needs some wrapping. 
But content LGTM!

- Joseph Wu


On Dec. 1, 2016, 4:12 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54275/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2016, 4:12 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This comment is inaccurate since the introduction of `LIBPROCESS_ADVERTISE_IP`,
> which introduced the distinction between the IP that we bind to vs advertise.
> 
> If the `--hostname` flag is unset, it is resolved from the IP address that the master/agent
advertises.
> This may happen to be same as the IP address that we bind to, but ultimately we resolve
it from the
> advertise IP.
> 
> 
> Diffs
> -----
> 
>   src/master/flags.cpp 9bfb40e22820c3ced40b128280ec63288fea8b41 
>   src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 
> 
> Diff: https://reviews.apache.org/r/54275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message