mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 54179: Updated master to use BoundedHashMap.
Date Wed, 30 Nov 2016 15:18:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54179/#review157412
-----------------------------------------------------------




src/master/master.hpp (line 2587)
<https://reviews.apache.org/r/54179/#comment228011>

    On reflection, this does change behavior slightly: previously, `completedTasks` could
contain multiple completed tasks with the same task ID (this is not illegal because frameworks
are allowed to reuse task IDs after the task has reached a terminal state). Using a `BoundedHashMap`
means we'll store at most a single completed task with a given ID. Do we want to preserve
the previous behavior?


- Neil Conway


On Nov. 29, 2016, 10:35 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54179/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 10:35 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6619
>     https://issues.apache.org/jira/browse/MESOS-6619
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This replaces a few instances where boost::circular_buffer was
> previously used.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f 
>   src/master/master.hpp b6c610b79aab146ece6b9be59be86f283d1c9ee8 
>   src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a 
> 
> Diff: https://reviews.apache.org/r/54179/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message