mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.
Date Tue, 29 Nov 2016 05:48:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53995/#review157204
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/http.cpp (line 2175)
<https://reviews.apache.org/r/53995/#comment227661>

    argument by reference: `Future<Nothing>&`



src/tests/api_tests.cpp (line 31)
<https://reviews.apache.org/r/53995/#comment227660>

    Remove this include?


- Anand Mazumdar


On Nov. 29, 2016, 5:38 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53995/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 5:38 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6473
>     https://issues.apache.org/jira/browse/MESOS-6473
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added API handler for ATTACH_CONTAINER_OUTPUT.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp e8b03c9f04b8a835f35ce7cb6cc44e3ecd799422 
>   src/internal/evolve.cpp 23a515c0aa8c31e0789fab84830dae32574604bc 
>   src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
>   src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb 
>   src/slave/validation.cpp b3d8bcd0f0855d2a0a96821900d996ba86e11578 
>   src/tests/api_tests.cpp 8889e7807ecead736eaac3910332e86d594e8cec 
> 
> Diff: https://reviews.apache.org/r/53995/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message