mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54112: Added support for http::connect to take an network::Address.
Date Tue, 29 Nov 2016 01:31:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54112/#review157187
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/include/process/http.hpp (lines 863 - 867)
<https://reviews.apache.org/r/54112/#comment227622>

    I only used URL in connect because I needed both scheme and the "host:port" (which is
either an IP / hostname and a port). Since this is just an address, we should probably just
have a single signature for this:
    
    ```
    Future<Connection> connect(const network::Address& address, bool ssl = false);
    ```
    
    Maybe a comment with a suggestion about the direction we'd like to take?


- Benjamin Mahler


On Nov. 28, 2016, 6:19 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54112/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for http::connect to take an network::Address.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp a684e09c8353112a0656b7e899a469c1e022e93b

>   3rdparty/libprocess/src/http.cpp 3f16f293a5c5cd0b31a85efe94cb6f8019543d45 
> 
> Diff: https://reviews.apache.org/r/54112/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message