mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53760: CMake: Changed example module output location and depedencies.
Date Mon, 28 Nov 2016 23:29:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53760/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 3:29 p.m.)


Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Changes
-------

Simplify the library output settings.  Instead of one property per project, we set it globally
instead.


Bugs: MESOS-5792
    https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
-------

This moves some test libraries from the default CMake build
output locations to `<build_dir>/src/.libs`, which is where
the Automake build outputs libraries.  We have a few tests
that expect modules to be located in this directory.

Additionally, this makes the test target (make check) depend
on the test modules and example frameworks, so that they are built
in the correct order.


Diffs (updated)
-----

  src/CMakeLists.txt 9ff47d7a95c3baa5aa10039039e5ad065180ba45 
  src/tests/CMakeLists.txt 90b92251b7e133124f6d9a896190ceea402cbff1 

Diff: https://reviews.apache.org/r/53760/diff/


Testing
-------

cmake ..
make clean
make


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message