mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 53768: CMake Cleanup: Generate protobufs with fewer dependencies.
Date Mon, 28 Nov 2016 19:16:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53768/#review157119
-----------------------------------------------------------


Ship it!




Ship It!

- Alex Clemmer


On Nov. 28, 2016, 6:48 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53768/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 6:48 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The protobuf sub-library only actually requires the protobuf
> dependencies in order to build.  Previously, it was dependent
> on all of libprocess.
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 
>   src/CMakeLists.txt 9ff47d7a95c3baa5aa10039039e5ad065180ba45 
> 
> Diff: https://reviews.apache.org/r/53768/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> make
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message