mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Hankinson <>
Subject Re: Review Request 53695: Allows caching extractable files when outputFile is set.
Date Mon, 28 Nov 2016 19:14:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 28, 2016, 7:14 p.m.)

Review request for mesos, Gilbert Song and Jie Yu.


Changes requested by reviewer.

Bugs: MESOS-6587

Repository: mesos


Allows caching extractable files when outputFile is set.

Diffs (updated)

  src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f 
  src/tests/fetcher_cache_tests.cpp 03e817d46194d451eceb70f4cebb54dfdcb4c2e7 



A new test, FetcherCacheTest.LocalCachedExtractCustomOutputFile, was created to confirm that
when a URI is created with cached: true, extract: true, a custom outputFile with a proper
compression suffix set, and an original URI that doesn't end with a proper compression suffix
fails to extract properly from the cache.

The test makes a copy of the test archive in the cache but appends "misc" to the end, forming
an invalid compression suffix, causing mesos-fetcher-test-archive.tgz to become mesos-fetcher-test-archive.tgzmisc.
The URI path is set to this modified location. The outputFile of the URI is set ARCHIVE_NAME
which ends with a valid compression suffix, so therefore should extract properly.

At the end of the test the temporary cached archive file (mesos-fetcher-test-archive.tgzmisc)
is deleted.

Before the patch was written this test was failing as expected. After implementing the patch,
this and all other tests were passing.


Stephen Hankinson

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message