mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 53770: CMake Cleanup: Alphabetize the list of sources.
Date Mon, 28 Nov 2016 18:48:54 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 28, 2016, 10:48 a.m.)

Review request for mesos, Alex Clemmer and Joris Van Remoortere.


Rebase on the switchboard changes.

Bugs: MESOS-5792

Repository: mesos


This alphabetizes the sources by variable name, and then by filename.
A few missing files were added and some duplicate files were removed.

Diffs (updated)

  src/CMakeLists.txt d6e213686a44fbca0ed841594ce803151224a5a7 



This being the final review in the chain, I ran the cmake build on several systems:

cmake ..
make check (OSX)
make check (CentOS 7)

sudo bin/mesos-tests --gtest_filter="*ROOT*" (CentOS 7)

These have reached parity with the automake build configured with `--disable-java --disable-python`.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message